Merge pull request DSpace#11762 from atmire/w2p-137948_harcode-values-subject-to-change-in-test-env

Fix test that can easily fail because of config changes by introducing test config

Author: tdonohue

dspace-api/src/test/data/dspaceFolder/config/local.cfg

@@ -203,3 +203,7 @@ assetstore.jcloud.subfolder = assetstore
 assetstore.jcloud.provider = filesystem
 assetstore.jcloud.container = assetstore-jclouds-container
 assetstore.jcloud.basedir = target/testing/dspace
+
+webui.submit.upload.required = true
+rest.cors.allowed-origins = http://localhost:4000
+dspace.name = DSpace at My University

dspace-server-webapp/src/test/java/org/dspace/app/rest/MetadatafieldRestRepositoryIT.java

@@ -81,24 +81,29 @@ public void setup() throws Exception {
     public void findAll() throws Exception {
 
         context.turnOffAuthorisationSystem();
-        MetadataField metadataField = MetadataFieldBuilder
-            .createMetadataField(context, "AnElement", "AQualifier", "AScopeNote").build();
-        context.restoreAuthSystemState();
 
         getClient().perform(get("/api/core/metadatafields")
-            .param("size", String.valueOf(100)))
+            .param("size", String.valueOf(9999)))
                    .andExpect(status().isOk())
                    .andExpect(content().contentType(contentType))
                    .andExpect(jsonPath("$._embedded.metadatafields", Matchers.hasItems(
                        MetadataFieldMatcher.matchMetadataFieldByKeys("dc", "title", null),
                        MetadataFieldMatcher.matchMetadataFieldByKeys("dc", "date", "issued"))
-                                      ))
+                                      ));
+    }
+
+    @Test
+    public void findAllPaginated() throws Exception {
+        getClient().perform(get("/api/core/metadatafields")
+                           .param("size", String.valueOf(2)))
+                   .andExpect(status().isOk())
+                   .andExpect(content().contentType(contentType))
+                   .andExpect(jsonPath("$._embedded.metadatafields", Matchers.notNullValue()))
                    .andExpect(jsonPath("$._links.first.href", Matchers.containsString("/api/core/metadatafields")))
                    .andExpect(jsonPath("$._links.self.href", Matchers.containsString("/api/core/metadatafields")))
                    .andExpect(jsonPath("$._links.next.href", Matchers.containsString("/api/core/metadatafields")))
                    .andExpect(jsonPath("$._links.last.href", Matchers.containsString("/api/core/metadatafields")))
-
-                   .andExpect(jsonPath("$.page.size", is(100)));
+                   .andExpect(jsonPath("$.page.size", is(2)));
     }
 
     @Test