Merge pull request DSpace#11914 from MMilosz/chore/errorprone-jdk17-pin-removal

Remove ErrorProne pin and bump to latest version for JDK 21

Author: alanorth

.github/dependabot.yml

@@ -135,10 +135,6 @@ updates:
       # Don't try to auto-update any DSpace dependencies
       - dependency-name: "org.dspace:*"
       - dependency-name: "org.dspace.*:*"
-      # Last version of errorprone to support JDK 17 is 2.42.0
-      # TODO: Remove this after this ticket is resolved https://github.com/DSpace/DSpace/issues/11621
-      - dependency-name: "com.google.errorprone:*"
-        versions: [ ">=2.43.0" ]
       # Don't automatically update BouncyCastle because maven-gpg-plugin REQUIRES a very specific version or release
       # errors will occur. See https://github.com/DSpace/DSpace/pull/11696
       - dependency-name: "org.bouncycastle:*"
@@ -277,9 +273,6 @@ updates:
       # Don't try to auto-update any DSpace dependencies
       - dependency-name: "org.dspace:*"
       - dependency-name: "org.dspace.*:*"
-      # Last version of errorprone to support JDK 17 is 2.42.0
-      - dependency-name: "com.google.errorprone:*"
-        versions: [ ">=2.43.0" ]
       # Don't automatically update BouncyCastle because maven-gpg-plugin REQUIRES a very specific version or release
       # errors will occur. See https://github.com/DSpace/DSpace/pull/11696
       - dependency-name: "org.bouncycastle:*"
@@ -418,9 +411,6 @@ updates:
       # Don't try to auto-update any DSpace dependencies
       - dependency-name: "org.dspace:*"
       - dependency-name: "org.dspace.*:*"
-      # Last version of errorprone to support JDK 17 is 2.42.0
-      - dependency-name: "com.google.errorprone:*"
-        versions: [ ">=2.43.0" ]
       # Don't automatically update BouncyCastle because maven-gpg-plugin REQUIRES a very specific version or release
       # errors will occur. See https://github.com/DSpace/DSpace/pull/11696
       - dependency-name: "org.bouncycastle:*"

pom.xml

@@ -30,7 +30,7 @@
         <solr.client.version>8.11.4</solr.client.version>
 
         <ehcache.version>3.11.1</ehcache.version>
-        <errorprone.version>2.42.0</errorprone.version>
+        <errorprone.version>2.47.0</errorprone.version>
         <!-- NOTE: when updating jackson.version, also sync jackson-annotations.version below -->
         <jackson.version>2.21.0</jackson.version>
         <jackson-annotations.version>2.21</jackson-annotations.version>
@@ -155,6 +155,8 @@
                             <arg>-XDcompilePolicy=simple</arg>
                             <arg>--should-stop=ifError=FLOW</arg>
                             <arg>-Xplugin:ErrorProne</arg>
+                            <!-- Required by Error Prone on JDK 21+: enables javac fix for JDK-8225377 -->
+                            <arg>-XDaddTypeAnnotationsToSymbol=true</arg>
                             <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED</arg>
                             <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</arg>
                             <arg>-J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED</arg>