Update ABI strategy errors and log level (#236)

Author: anastasiarods

.changeset/silver-gifts-chew.md

@@ -0,0 +1,5 @@
+---
+'@3loop/transaction-decoder': patch
+---
+
+Update ABI strategy errors and log levels

packages/transaction-decoder/src/abi-loader.ts

@@ -202,7 +202,7 @@ export const AbiLoaderRequestResolver = RequestResolver.makeBatched((requests: A
             strategyId: 'address-batch',
           })
           .pipe(
-            Effect.tapError(Effect.logWarning),
+            Effect.tapError(Effect.logDebug),
             Effect.orElseSucceed(() => null),
             Effect.map((result) => (result ? Either.left(result) : Either.right(req))),
           )
@@ -234,7 +234,7 @@ export const AbiLoaderRequestResolver = RequestResolver.makeBatched((requests: A
             strategyId: 'fragment-batch',
           })
           .pipe(
-            Effect.tapError(Effect.logWarning),
+            Effect.tapError(Effect.logDebug),
             Effect.orElseSucceed(() => null),
           ) // If no strategies found, return null
       },

packages/transaction-decoder/src/abi-strategy/blockscout-abi.ts

@@ -91,7 +91,9 @@ export const BlockscoutStrategyResolver = (config: {
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('Blockscout', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('Blockscout', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.BlockscoutStrategyResolver',

packages/transaction-decoder/src/abi-strategy/etherscan-abi.ts

@@ -136,7 +136,9 @@ export const EtherscanStrategyResolver = (config?: {
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('etherscan', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('etherscan', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.EtherscanStrategyResolver',

packages/transaction-decoder/src/abi-strategy/etherscanv2-abi.ts

@@ -99,7 +99,9 @@ export const EtherscanV2StrategyResolver = (config?: {
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('etherscanV2', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('etherscanV2', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.EtherscanV2StrategyResolver',

packages/transaction-decoder/src/abi-strategy/experimental-erc20.ts

@@ -6,13 +6,15 @@ import { erc20Abi, getAddress, getContract } from 'viem'
 const getLocalFragments = (service: PublicClient, { address, chainId }: RequestModel.GetContractABIStrategyParams) =>
   Effect.gen(function* () {
     if (!address)
-      return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId))
+      return yield* Effect.fail(
+        new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId, 'Address is required'),
+      )
 
     const client = yield* service
       .getPublicClient(chainId)
       .pipe(
-        Effect.catchAll(() =>
-          Effect.fail(new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId)),
+        Effect.catchAll((e) =>
+          Effect.fail(new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId, String(e))),
         ),
       )
 
@@ -23,14 +25,12 @@ const getLocalFragments = (service: PublicClient, { address, chainId }: RequestM
           address: getAddress(address),
           client: client.client,
         }),
-      catch: () => {
-        throw new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId)
-      },
+      catch: (e) => new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId, String(e)),
     })
 
     const decimals = yield* Effect.tryPromise({
       try: () => inst.read.decimals(),
-      catch: () => new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId),
+      catch: (e) => new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId, String(e)),
     })
 
     if (decimals != null) {

packages/transaction-decoder/src/abi-strategy/fourbyte-abi.ts

@@ -119,7 +119,12 @@ export const FourByteStrategyResolver = (): RequestModel.ContractAbiResolverStra
             )
           } else {
             return yield* Effect.fail(
-              new RequestModel.ResolveStrategyABIError('4byte.directory', req.address, req.chainId),
+              new RequestModel.ResolveStrategyABIError(
+                '4byte.directory',
+                req.address,
+                req.chainId,
+                String(result.cause),
+              ),
             )
           }
         }),

packages/transaction-decoder/src/abi-strategy/openchain-abi.ts

@@ -136,7 +136,9 @@ export const OpenchainStrategyResolver = (): RequestModel.ContractAbiResolverStr
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('openchain', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('openchain', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.OpenchainStrategyResolver',

packages/transaction-decoder/src/abi-strategy/request-model.ts

@@ -1,4 +1,4 @@
-import { Effect, RateLimiter } from 'effect'
+import { Data, Effect, RateLimiter } from 'effect'
 
 export interface FetchABIParams {
   readonly chainID: number
@@ -7,25 +7,35 @@ export interface FetchABIParams {
   readonly signature?: string | undefined
 }
 
-export class ResolveStrategyABIError {
-  readonly _tag = 'ResolveStrategyABIError'
-  constructor(
-    readonly resolverName: string,
-    readonly address: string,
-    readonly chain: number,
-  ) {}
+export class ResolveStrategyABIError extends Data.TaggedError('ResolveStrategyABIError')<{
+  resolver: string
+  address: string
+  chainID: number
+  message: string
+}> {
+  constructor(resolver: string, address: string, chainID: number, message: string) {
+    super({ resolver, address, chainID, message })
+  }
 }
 
-export class MissingABIStrategyError {
-  readonly _tag = 'MissingABIStrategyError'
+export class MissingABIStrategyError extends Data.TaggedError('MissingABIStrategyError')<{
+  address: string
+  chainId: number
+  strategyId: string
+  event?: string
+  signature?: string
+  message: string
+}> {
   constructor(
-    readonly address: string,
-    readonly chainId: number,
-    readonly strategyId: string,
-    readonly event?: string,
-    readonly signature?: string,
-    readonly message: string = 'Missing contract ABI',
-  ) {}
+    address: string,
+    chainId: number,
+    strategyId: string,
+    event?: string,
+    signature?: string,
+    message = 'Missing contract ABI',
+  ) {
+    super({ address, chainId, strategyId, event, signature, message })
+  }
 }
 
 interface FunctionFragmentABI {

packages/transaction-decoder/src/abi-strategy/sourcify-abi.ts

@@ -96,7 +96,9 @@ export const SourcifyStrategyResolver = (): RequestModel.ContractAbiResolverStra
               ),
             )
           } else {
-            return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('sourcify', req.address, req.chainId))
+            return yield* Effect.fail(
+              new RequestModel.ResolveStrategyABIError('sourcify', req.address, req.chainId, String(result.cause)),
+            )
           }
         }),
         'AbiStrategy.SourcifyStrategyResolver',