Add normalizer fixture to make test implementation easier + fix CS

Author: apfelbox

src/Normalizer/SimpleNormalizer.php

@@ -2,7 +2,6 @@
 
 namespace Torr\SimpleNormalizer\Normalizer;
 
-use Doctrine\Common\Util\ClassUtils;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Mapping\ClassMetadataFactory;
 use Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException;
@@ -136,6 +135,10 @@ private function recursiveNormalize (mixed $value, array $context = []) : mixed
 
 	/**
 	 * Normalizes the class name
+	 *
+	 * @param class-string $className
+	 *
+	 * @return class-string
 	 */
 	private function normalizeClassName (string $className) : string
 	{

tests/Fixture/DummyVONormalizer.php

@@ -0,0 +1,26 @@
+<?php declare(strict_types=1);
+
+namespace Tests\Torr\SimpleNormalizer\Fixture;
+
+use Torr\SimpleNormalizer\Normalizer\SimpleNormalizer;
+use Torr\SimpleNormalizer\Normalizer\SimpleObjectNormalizerInterface;
+
+/**
+ * @final
+ */
+readonly class DummyVONormalizer implements SimpleObjectNormalizerInterface
+{
+	public function __construct (
+		private mixed $returnValue = null,
+	) {}
+
+	public function normalize (object $value, array $context, SimpleNormalizer $normalizer) : mixed
+	{
+		return $this->returnValue;
+	}
+
+	public static function getNormalizedType () : string
+	{
+		return DummyVO::class;
+	}
+}

tests/Normalizer/SimpleNormalizerTest.php

@@ -9,9 +9,9 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ServiceLocator;
 use Tests\Torr\SimpleNormalizer\Fixture\DummyVO;
+use Tests\Torr\SimpleNormalizer\Fixture\DummyVONormalizer;
 use Torr\SimpleNormalizer\Exception\IncompleteNormalizationException;
 use Torr\SimpleNormalizer\Normalizer\SimpleNormalizer;
-use Torr\SimpleNormalizer\Normalizer\SimpleObjectNormalizerInterface;
 use Torr\SimpleNormalizer\Normalizer\Validator\ValidJsonVerifier;
 
 /**
@@ -136,17 +136,7 @@ public function testWithoutEntityManager () : void
 		$locator->expects(self::once())
 			->method("get")
 			->with(DummyVO::class)
-			->willReturn(new readonly class implements SimpleObjectNormalizerInterface {
-				public function normalize (object $value, array $context, SimpleNormalizer $normalizer) : int
-				{
-					return 5;
-				}
-
-				public static function getNormalizedType () : string
-				{
-					return DummyVO::class;
-				}
-			});
+			->willReturn(new DummyVONormalizer(5));
 
 		$normalizer = new SimpleNormalizer(
 			objectNormalizers: $locator,
@@ -176,17 +166,7 @@ public function testWithEntityManagerButNoMapping () : void
 		$locator->expects(self::once())
 			->method("get")
 			->with(DummyVO::class)
-			->willReturn(new readonly class implements SimpleObjectNormalizerInterface {
-				public function normalize (object $value, array $context, SimpleNormalizer $normalizer) : int
-				{
-					return 5;
-				}
-
-				public static function getNormalizedType () : string
-				{
-					return DummyVO::class;
-				}
-			});
+			->willReturn(new DummyVONormalizer(5));
 
 		$normalizer = new SimpleNormalizer(
 			objectNormalizers: $locator,
@@ -225,17 +205,7 @@ public function testWithEntityManagerWithMapping () : void
 		$locator->expects(self::once())
 			->method("get")
 			->with("SomeClass")
-			->willReturn(new readonly class implements SimpleObjectNormalizerInterface {
-				public function normalize (object $value, array $context, SimpleNormalizer $normalizer) : int
-				{
-					return 5;
-				}
-
-				public static function getNormalizedType () : string
-				{
-					return DummyVO::class;
-				}
-			});
+			->willReturn(new DummyVONormalizer(5));
 
 		$normalizer = new SimpleNormalizer(
 			objectNormalizers: $locator,
@@ -253,21 +223,7 @@ public static function getNormalizedType () : string
 	private function createNormalizerObjectNormalizers (mixed $returnValue) : ServiceLocator
 	{
 		return new ServiceLocator([
-			DummyVO::class => static fn () => new readonly class($returnValue) implements SimpleObjectNormalizerInterface {
-				public function __construct (
-					private mixed $returnValue,
-				) {}
-
-				public function normalize (object $value, array $context, SimpleNormalizer $normalizer) : mixed
-				{
-					return $this->returnValue;
-				}
-
-				public static function getNormalizedType () : string
-				{
-					return DummyVO::class;
-				}
-			},
+			DummyVO::class => static fn () => new DummyVONormalizer($returnValue),
 		]);
 	}
 }